Drop legacy runtime routes#175
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 769b71bfac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| gcloud scheduler jobs update http "${job_name}" \ | ||
| --project="${GCP_PROJECT_ID}" \ | ||
| --location="${scheduler_location}" \ | ||
| --uri="${scheduler_uri}" \ |
There was a problem hiding this comment.
Please set or verify the Cloud Scheduler OIDC audience when changing the main job target to a pathful URI. Google Cloud Scheduler documents that, when the Audience is not specified, the entire target URL is used as the OIDC aud, while Cloud Run service-to-service auth requires aud to remain the service URL even when requesting a specific path; for jobs created with the default audience, this update makes the main scheduler send an audience like ${service_url}/run, causing authenticated Cloud Run invocations to be rejected after the sync.
Useful? React with 👍 / 👎.
| case "${suffix}" in | ||
| scheduler) | ||
| schedule_time="${main_time}" | ||
| scheduler_path="/run" |
There was a problem hiding this comment.
This changes the main Cloud Scheduler job to target /run, but scripts/execution_report_heartbeat.py still treats only path / as a strategy-run scheduler (_scheduler_job_targets_strategy_run returns false for any other path). After this sync, scheduler-aware heartbeat checks will see no matching main scheduler jobs and conservatively require reports for every configured service, causing false heartbeat failures for services whose main scheduler was not actually due.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests